Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: svn commit: r2431 - branches/fsvs-1.2.x/fsvs/src/status.c

fsvs
Discussion topic

Back to topic list

Re: svn commit: r2431 - branches/fsvs-1.2.x/fsvs/src/status.c

Author tekknokra
Full name Gunnar Thielebein
Date 2010-02-15 07:38:53 PST
Message Hi Phil,

Would you point me how to use tests in fsvs?
I can't get them running.
When I ./run-tests <test> this does not return anything.
For writing a test for the dir_exclude_mtime option. Should I use the 034_status
   036_status_non-recursive (?). What should the test include?

Best,
Gunnar

Ph. Marek wrote:
> On Saturday 13 February 2010 Gunnar Thielebein wrote:
>> Author: tekknokrat
>> Date: 2010-02-13 09:56:59-0800
>> New Revision: 2431
>>
>> Modified:
>> branches/fsvs-1.2.x/​fsvs/src/status.c
>>
>> Log:
>> - change behavior in stop_change, don't stop on parent nodes containing
>> changed entries
>>
>> Modified: branches/fsvs-1.2.x/​fsvs/src/status.c
>> Url:
>> http://fsvs.tigris.o​rg/source/browse/fsv​s/branches/fsvs-1.2.​x/fsvs/src/sta
>> tus.c?view=diff&​pathrev=2431&r1=​2430&r2=2431
>> ====================​====================​====================​==============
>> ==== --- branches/fsvs-1.2.x/​fsvs/src/status.c (original)
>> +++ branches/fsvs-1.2.x/​fsvs/src/status.c 2010-02-13 09:56:59-0800
>> @@ -351,11 +351,8 @@
>> if (hlp__only_dir_mtime​_changed(sts))
>> return status;
>>
>> - /*
>> - * @todo: this still exit(1) for excluded dir, why?
>> - */
>> - if (opt__get_int(OPT__S​TOP_ON_CHANGE) &&
>> - sts->entry_status)
>> + if (opt__get_int(OPT__S​TOP_ON_CHANGE) &&
>> + sts->entry_status && (!(sts->entry_status & FS_CHILD_CHANGED)))
>> /* Status is a read-only operation, so that works. */
>> exit(1);
>>
> I'm not fully sure that this is correct.
>
> What about directories with new/deleted entries in them, when the filter
> doesn't include "new,deleted"?
>
> Hmmm ... if the filter says "new not wanted", should we stop if there's a
> changed directory? Perhaps no, because that would defeat the filter
> definition.
> So your change might be correct.
>
> Did you verify the test status?
>
>
> Regards,
>
> Phil
>
>

« Previous message in topic | 3 of 5 | Next message in topic »

Messages

Show all messages in topic

Re: svn commit: r2431 - branches/fsvs-1.2.x/fsvs/src/status.c pmarek P.Marek 2010-02-13 10:24:14 PST
     Re: svn commit: r2431 - branches/fsvs-1.2.x/fsvs/src/status.c tekknokra Gunnar Thielebein 2010-02-13 11:49:59 PST
     Re: svn commit: r2431 - branches/fsvs-1.2.x/fsvs/src/status.c tekknokra Gunnar Thielebein 2010-02-15 07:38:53 PST
         Re: svn commit: r2431 - branches/fsvs-1.2.x/fsvs/src/status.c pmarek P.Marek 2010-02-15 09:32:37 PST
             svn commit: r2432 tekknokra Gunnar Thielebein 2010-02-16 02:25:57 PST
Messages per page: