Login | Register
My pages Projects Community openCollabNet

Discussions > dev > dir_exclude_mtime option

fsvs
Discussion topic

Hide all messages in topic

All messages in topic

Re: dir_exclude_mtime option

Author pmarek
Full name P.Marek
Date 2010-02-13 07:57:18 PST
Message On Saturday 13 February 2010 Gunnar Thielebein wrote:
> the fastest... :-)
> Nice to know that you can leave off the param of a function.
Well, the name of a function returns the address ... which is hardly ever
NULL, so the if is always true ...


--
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

Re: dir_exclude_mtime option

Author tekknokra
Full name Gunnar Thielebein
Date 2010-02-13 07:55:13 PST
Message Hi Phil,

the fastest... :-)
Nice to know that you can leave off the param of a function.

Best,
Gunnar


P.Marek wrote:
> Hello Gunnar!
>
> On Saturday 13 February 2010 Gunnar Thielebein wrote:
>> Thanks for the hint and the changes. I updated the new version and i looks
>> more clear now. For sure the helper function needs to be before the
>> ostop_change. The issue is now with 2429 that it doesnt detect any changes
>> anymore.
>> I tried with mtime update and with changing a file and this changes are not
>> shown. May you have a look on the new check I am not very good with
>> arethmetical expressions!
> It's not the arithmetic ... see r2430.
>
>
> Regards,
>
> Phil
>
>

Re: dir_exclude_mtime option

Author pmarek
Full name P.Marek
Date 2010-02-13 07:00:24 PST
Message Hello Gunnar!

On Saturday 13 February 2010 Gunnar Thielebein wrote:
> Thanks for the hint and the changes. I updated the new version and i looks
> more clear now. For sure the helper function needs to be before the
> ostop_change. The issue is now with 2429 that it doesnt detect any changes
> anymore.
> I tried with mtime update and with changing a file and this changes are not
> shown. May you have a look on the new check I am not very good with
> arethmetical expressions!
It's not the arithmetic ... see r2430.


Regards,

Phil


--
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

Re: dir_exclude_mtime option

Author pmarek
Full name P.Marek
Date 2010-02-13 05:07:53 PST
Message Hello Gunnar!

On Saturday 13 February 2010 Gunnar Thielebein wrote:
> I also checked in a first version of the new option in [2427].
Thank you. Please update, I've re-sorted the documentation and changed the
text a bit.

> This already works like I want it for dirs where only the mtime changes.
> If other metadata changes they will still be shown with status.
> What I need for my script is also an integration with the stop_change
> option. But here I still get an exitcode > 0 with the dir_exclude_mtime
> option enabled on mtime-only changed folders.
> How can I change the condition to support the dir_exclude_mtime option? Any
> idea on your side?
>
> > if ( opt__get_int(OPT__ST​OP_ON_CHANGE) && sts->entry_status
~ is binary NOT, ! is logical NOT.
Please update ;-)


Would you mind writing a test for that, too?


Regards,

Phil

--
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

dir_exclude_mtime option

Author tekknokra
Full name Gunnar Thielebein
Date 2010-02-13 04:28:08 PST
Message Hi Phil,

I also checked in a first version of the new option in [2427].

This already works like I want it for dirs where only the mtime changes.
If other metadata changes they will still be shown with status.
What I need for my script is also an integration with the stop_change option.
But here I still get an exitcode > 0 with the dir_exclude_mtime option enabled
on mtime-only changed folders.
How can I change the condition to support the dir_exclude_mtime option? Any idea
on your side?
> if ( opt__get_int(OPT__ST​OP_ON_CHANGE) && sts->entry_status

Cheers,
Gunnar
Messages per page: