Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: FSVS on gentoo crashes

fsvs
Discussion topic

2020-03-13: This site is going to be decommissioned and shut down very soon. Please copy and archive any data you wish to keep ASAP

Hide all messages in topic

All messages in topic

Re: FSVS on gentoo crashes

Author pmarek
Full name P.Marek
Date 2007-11-15 02:15:18 PST
Message On Thursday 15 November 2007 Alexander Skwar wrote:
> Hello!
...
> That fixed the problem! Hurray!
>
> So I suppose you don't need to logon anymore, do you?
No, thank you.
>
> Thanks a lot for fixing the problem!
You're welcome.
Thanks a lot for reporting that!


Regards,

Phil


--
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

Re: FSVS on gentoo crashes

Author Alexander Skwar <a dot skwar at gmail dot com>
Full name Alexander Skwar <a dot skwar at gmail dot com>
Date 2007-11-15 02:06:22 PST
Message Hello!

On Nov 15, 2007 9:25 AM, Philipp Marek <philipp at marek dot priv dot at> wrote:
> Thank you, Alexander.
>
> Committed as r1213.
>
> Index: src/direnum.c
> ====================​====================​====================​=======
> --- src/direnum.c (Revision 1212)
> +++ src/direnum.c (Arbeitskopie)
> @@ -503,6 +503,10 @@ int dir__enumerator(struct estat *this,
> * How much should we add? For now, just give about 30%. */
> /* size*21: Let's hope that this won't overflow :-) */
> size=(size*21)/16;
> + /* If +20% is not at least the buffer size (FREE_SPACE),
> + * take at least that much memory. */
> + if (size < mark+FREE_SPACE) size=mark+FREE_SPACE;
> +
> strings=realloc(strings, size);
> DEBUGP("strings realloc(%p, %d)", strings, size);
> STOPIF_ENOMEM( !strings);

That fixed the problem! Hurray!

So I suppose you don't need to logon anymore, do you?

Thanks a lot for fixing the problem!
Alexander

Re: FSVS on gentoo crashes

Author pmarek
Full name P.Marek
Date 2007-11-15 00:25:42 PST
Message Thank you, Alexander.

Committed as r1213.

Index: src/direnum.c
====================​====================​====================​=======
--- src/direnum.c (Revision 1212)
+++ src/direnum.c (Arbeitskopie)
@@ -503,6 +503,10 @@ int dir__enumerator(struct estat *this,
                         * How much should we add? For now, just give about 30%. */
                        /* size*21: Let's hope that this won't overflow :-) */
                        size=(size*21)/16;
+ /* If +20% is not at least the buffer size (FREE_SPACE),
+ * take at least that much memory. */
+ if (size < mark+FREE_SPACE) size=mark+FREE_SPACE;
+
                        strings=realloc(strings, size);
                        DEBUGP("strings realloc(%p, %d)", strings, size);
                        STOPIF_ENOMEM( !strings);


--
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

Re: FSVS on gentoo crashes

Author pmarek
Full name P.Marek
Date 2007-11-15 00:09:42 PST
Message I was just able to reproduce that ... so expect a fix soon.

--
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

Re: FSVS on gentoo crashes

Author pmarek
Full name P.Marek
Date 2007-11-15 00:05:42 PST
Message On Thursday 15 November 2007 Alexander Skwar wrote:
> But I can also provide you access again. Tonight?
I could do that now, too.

> I also just uploaded my fsvs directory to
> <http://public-files.​askwar.s3.amazonaws.​com/fsvs_svn_askwar.​tar.bz2>.
> Size: 1013622 bytes.
Thank you ... that answers my immediate questions.


--
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

Re: FSVS on gentoo crashes

Author Alexander Skwar <a dot skwar at gmail dot com>
Full name Alexander Skwar <a dot skwar at gmail dot com>
Date 2007-11-14 23:43:39 PST
Message Hi.

On Nov 15, 2007 8:25 AM, Philipp Marek <philipp at marek dot priv dot at> wrote:
> On Thursday 15 November 2007 Alexander Skwar wrote:
> > Done as you "commanded" :)
> >
> > Attached is the diff and a new valgrind log.
>
> Might I sometimes take a look over VNC again, or do you want to answer
> questions like "do you have HAVE_GETDENTS64 defined in config.h" manually?

--(askwar@winnb00048​8)-(78/pts/33)-(08:4​3:00/2007-11-15)--
--($:~/Source/fsvs/​fsvs_svn/fsvs/fsvs/f​svs/src)-- grep HAVE_GETD config.h
--(askwar@winnb00048​8)-(79/pts/33)-(08:4​3:03/2007-11-15)--
--($:~/Source/fsvs/​fsvs_svn/fsvs/fsvs/f​svs/src)--

--(askwar@winnb00048​8)-(80/pts/33)-(08:4​3:18/2007-11-15)--
--($:~/Source/fsvs/​fsvs_svn/fsvs/fsvs/f​svs)-- grep -r HAVE_GETD .
./src/tags:HAVE_GETDENTS64 direnum.c 57;" d file:
./src/tags:HAVE_GETDENTS64 direnum.c 62;" d file:
./src/direnum.c~:#undef HAVE_GETDENTS64
./src/direnum.c~:#define HAVE_GETDENTS64 1
./src/direnum.c~:#ifdef HAVE_GETDENTS64
./src/.svn/text-base​/direnum.c.svn-base:​#undef HAVE_GETDENTS64
./src/.svn/text-base​/direnum.c.svn-base:​#define HAVE_GETDENTS64 1
./src/.svn/text-base​/direnum.c.svn-base:​#ifdef HAVE_GETDENTS64
./src/direnum.c:#undef HAVE_GETDENTS64
./src/direnum.c:#define HAVE_GETDENTS64 1
./src/direnum.c:#ifdef HAVE_GETDENTS64
./autom4te.cache/tra​ces.0:m4trace:config​ure.in:196: -1-
AH_OUTPUT([HAVE_GETDENTS64], [/* Define to 1 if you have the
`getdents64\' function. */
./autom4te.cache/tra​ces.0:#undef HAVE_GETDENTS64])

But I can also provide you access again. Tonight?

I also just uploaded my fsvs directory to
<http://public-files.​askwar.s3.amazonaws.​com/fsvs_svn_askwar.​tar.bz2>.
Size: 1013622 bytes.

Alexander

Re: FSVS on gentoo crashes

Author pmarek
Full name P.Marek
Date 2007-11-14 23:25:37 PST
Message On Thursday 15 November 2007 Alexander Skwar wrote:
> Done as you "commanded" :)
>
> Attached is the diff and a new valgrind log.

Might I sometimes take a look over VNC again, or do you want to answer
questions like "do you have HAVE_GETDENTS64 defined in config.h" manually?


Regards,

Phil



--
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

Re: FSVS on gentoo crashes

Author Alexander Skwar <a dot skwar at gmail dot com>
Full name Alexander Skwar <a dot skwar at gmail dot com>
Date 2007-11-14 23:04:36 PST
Message Phil,

On Nov 14, 2007 6:01 PM, Philipp Marek <philipp at marek dot priv dot at> wrote:
> On Wednesday 14 November 2007 Philipp Marek wrote:
> > Sorry - I forgot to say ... could you please either
> > - revert your sources, or
> > - send me the output of "svn diff",
> >
> > so that I have the same sources and can use the line numbers?
>
> On second thought ... can you take a diff, revert, and re-run valgrind?

Done as you "commanded" :)

Attached is the diff and a new valgrind log.


--($:/net/Winds06/o​pt/apps/Gentoo/HomeS​mall/rootfs/bauen/va​r/log/portage/elog)-​-
SVN_SSH="ssh -i /home/askwar/.ssh/fs​vs-root@winnb000488"​ sudo
/home/askwar/bin/valgrind --leak-check=full --show-reachable=yes
--num-callers=15 --log-file=/tmp/valg​rind-fsvs_svn.out
--time-stamp=yes
/home/askwar/bin/../​Source/fsvs/fsvs_svn​/fsvs/fsvs/fsvs/src/​fsvs st


An error occurred: Ungültige Adresse (14)
  in dir__enumerator: Speicherzugriffsfehler


Thanks a lot for all the time so far,

Alexander
Attachments

Re: FSVS on gentoo crashes

Author pmarek
Full name P.Marek
Date 2007-11-14 09:01:40 PST
Message On Wednesday 14 November 2007 Philipp Marek wrote:
> Sorry - I forgot to say ... could you please either
> - revert your sources, or
> - send me the output of "svn diff",
>
> so that I have the same sources and can use the line numbers?

On second thought ... can you take a diff, revert, and re-run valgrind?


--
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

Re: FSVS on gentoo crashes

Author pmarek
Full name P.Marek
Date 2007-11-14 08:19:49 PST
Message Hello Alexander,

On Wednesday 14 November 2007 Alexander Skwar wrote:
...
> Attached you can find the logfile. I ran:
>
> --($:/net/Winds06/o​pt/apps/Gentoo/HomeS​mall/rootfs/bauen/va​r/log/portage)--
> SVN_SSH="ssh -i /home/askwar/.ssh/fs​vs-root@winnb000488"​ sudo
> /home/askwar/bin/valgrind --leak-check=full --show-reachable=yes
> --num-callers=15 --log-file=/tmp/valgrind.out --time-stamp=yes
> /home/askwar/bin/../​Source/fsvs/fsvs_svn​/fsvs/fsvs/fsvs/src/​fsvs st
>
>
> An error occurred: Ungültige Adresse (14)
> in dir__enumerator: Speicherzugriffsfehler
Sorry - I forgot to say ... could you please either
- revert your sources, or
- send me the output of "svn diff",

so that I have the same sources and can use the line numbers?


Thank you!


--
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

Re: FSVS on gentoo crashes

Author Alexander Skwar <a dot skwar at gmail dot com>
Full name Alexander Skwar <a dot skwar at gmail dot com>
Date 2007-11-14 07:05:27 PST
Message Hallo!

On Nov 13, 2007 6:28 PM, Philipp Marek <philipp at marek dot priv dot at> wrote:
> On Tuesday 13 November 2007 Alexander Skwar wrote:
> > Hello Phil!
> >
> > On Nov 9, 2007 6:04 PM, Philipp Marek <philipp at marek dot priv dot at> wrote:
> > > On Friday 09 November 2007 Philipp Marek wrote:
> > > > ... It seems that you have at least to patch configure.in, so that
> > > > libc6=2.7 gets accepted - I'd suggest just changing the 2.6 to 2.7,
> > > > that could work.
> ...
> > That patch worked just fine. Now, what do I do with valgrind? :)
>
> On Friday 09 November 2007 Philipp Marek wrote:
> > and try this:
> >valgrind --leak-check=full --show-reachable=yes --num-callers=15 --log-file=/tmp/valgrind.out --time-stamp=yes ~...fsvs st
> >
> > Please send me the logfile (can be privately, if you prefer).

Oh. Sorry. Missed that :)

Attached you can find the logfile. I ran:

--($:/net/Winds06/o​pt/apps/Gentoo/HomeS​mall/rootfs/bauen/va​r/log/portage)--
SVN_SSH="ssh -i /home/askwar/.ssh/fs​vs-root@winnb000488"​ sudo
/home/askwar/bin/valgrind --leak-check=full --show-reachable=yes
--num-callers=15 --log-file=/tmp/valgrind.out --time-stamp=yes
/home/askwar/bin/../​Source/fsvs/fsvs_svn​/fsvs/fsvs/fsvs/src/​fsvs st


An error occurred: Ungültige Adresse (14)
  in dir__enumerator: Speicherzugriffsfehler

Alexander
Attachments

Re: FSVS on gentoo crashes

Author pmarek
Full name P.Marek
Date 2007-11-13 09:28:15 PST
Message On Tuesday 13 November 2007 Alexander Skwar wrote:
> Hello Phil!
>
> On Nov 9, 2007 6:04 PM, Philipp Marek <philipp at marek dot priv dot at> wrote:
> > On Friday 09 November 2007 Philipp Marek wrote:
> > > ... It seems that you have at least to patch configure.in, so that
> > > libc6=2.7 gets accepted - I'd suggest just changing the 2.6 to 2.7,
> > > that could work.
...
> That patch worked just fine. Now, what do I do with valgrind? :)

On Friday 09 November 2007 Philipp Marek wrote:
> and try this:
>        valgrind --leak-check=full --show-reachable=yes --num-callers=15 --log-file=/tmp/valgrind.out --time-stamp=yes ~...fsvs st
>
> Please send me the logfile (can be privately, if you prefer).


;-)

--
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

Re: FSVS on gentoo crashes

Author Alexander Skwar <a dot skwar at gmail dot com>
Full name Alexander Skwar <a dot skwar at gmail dot com>
Date 2007-11-13 05:07:36 PST
Message Hello Phil!

On Nov 9, 2007 6:04 PM, Philipp Marek <philipp at marek dot priv dot at> wrote:
> On Friday 09 November 2007 Philipp Marek wrote:
> > ... It seems that you have at least to patch configure.in, so that
> > libc6=2.7 gets accepted - I'd suggest just changing the 2.6 to 2.7, that
> > could work.
> About this: (untested)
>
> diff -u configure.in.orig configure.in
> --- configure.in.orig 2007-11-09 17:38:56.000000000 +0100
> +++ configure.in 2007-11-09 18:03:45.000000000 +0100
> @@ -467,6 +467,8 @@
> ],
> libc="aix5")
>
> +libc="2.6"
> +
> AC_MSG_CHECKING([the libc version])
>
> case "${libc}" in

That patch worked just fine. Now, what do I do with valgrind? :)

Alexander

Re: FSVS on gentoo crashes

Author pmarek
Full name P.Marek
Date 2007-11-09 09:04:29 PST
Message On Friday 09 November 2007 Philipp Marek wrote:
> ... It seems that you have at least to patch configure.in, so that
> libc6=2.7 gets accepted - I'd suggest just changing the 2.6 to 2.7, that
> could work.
About this: (untested)

diff -u configure.in.orig configure.in
--- configure.in.orig 2007-11-09 17:38:56.000000000 +0100
+++ configure.in 2007-11-09 18:03:45.000000000 +0100
@@ -467,6 +467,8 @@
 ],
 libc="aix5")

+libc="2.6"
+
 AC_MSG_CHECKING([the libc version])

 case "${libc}" in


Regards,

Phil


--
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

Re: FSVS on gentoo crashes

Author pmarek
Full name P.Marek
Date 2007-11-09 08:42:49 PST
Message Hello Alexander!

On Friday 09 November 2007 Alexander Skwar wrote:
> I'll try this on Monday; right now I don't have access to the system.
Thank you. It seems that you have at least to patch configure.in, so that
libc6=2.7 gets accepted - I'd suggest just changing the 2.6 to 2.7, that
could work.


Regards,

Phil


--
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

Re: FSVS on gentoo crashes

Author Alexander Skwar <a dot skwar at gmail dot com>
Full name Alexander Skwar <a dot skwar at gmail dot com>
Date 2007-11-09 08:39:23 PST
Message Hi!

On Nov 9, 2007 5:09 PM, Philipp Marek <philipp at marek dot priv dot at> wrote:
> Hello Alexander,
>
>
> would you please check out the current valgrind sources

I'll try this on Monday; right now I don't have access to the system.

Alexander

Re: FSVS on gentoo crashes

Author pmarek
Full name P.Marek
Date 2007-11-09 08:09:31 PST
Message Hello Alexander,


would you please check out the current valgrind sources

    svn co svn://svn.valgrind.o​rg/valgrind/trunk valgrind
    cd valgrind
    ./autogen.sh
    ./configure --prefix=...
    make
    make install
(from http://valgrind.org/​downloads/repository​.html)

and try this:
    valgrind --leak-check=full --show-reachable=yes --num-callers=15 --log-file=/tmp/valgrind.out --time-stamp=yes ~...fsvs st

Please send me the logfile (can be privately, if you prefer).


Thank you!


Regards,

Phil


--
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!
Messages per page: