Login | Register
My pages Projects Community openCollabNet

Discussions > issues > [Issue 20] CHANGES file misleads about which version which changes are in

fsvs
Discussion topic

Hide all messages in topic

All messages in topic

[Issue 20] CHANGES file misleads about which version which changes are in

Author pmarek
Full name P.Marek
Date 2015-07-27 00:10:29 PDT
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=20



User pmarek changed the following:

                What |Old value |New value
====================​====================​====================​====================​
                  Status|NEW |RESOLVED
--------------------​--------------------​--------------------​--------------------​
              Resolution| |FIXED
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from pmarek at tigris dot org Mon Jul 27 00:10:28 -0700 2015 -------
Is that *so* important? ;)

thanks.

[Issue 20] CHANGES file misleads about which version which changes are in

Author ryandesign
Full name Ryan Schmidt
Date 2015-07-27 00:05:59 PDT
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=20



User ryandesign changed the following:

                What |Old value |New value
====================​====================​====================​====================​
     Attachment is patch| |Created an attachment (id=
                        | |11)
proposed patch

--------------------​--------------------​--------------------​--------------------​




------- Additional comments from ryandesign at tigris dot org Mon Jul 27 00:05:57 -0700 2015 -------
Created an attachment (id=11)
proposed patch

[Issue 20] New - CHANGES file misleads about which version which changes are in

Author ryandesign
Full name Ryan Schmidt
Date 2015-07-27 00:05:22 PDT
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=20
                 Issue #|20
                 Summary|CHANGES file misleads about which version which change
                        |s are in
               Component|fsvs
                 Version|current
                Platform|Linux
              OS/Version|All
                     URL|
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|core
             Assigned to|pmarek
             Reported by|ryandesign






------- Additional comments from ryandesign at tigris dot org Mon Jul 27 00:05:21 -0700 2015 -------
The CHANGES file is not accurate with regard to which version contains which changes.

For example, the CHANGES file distributed with version 1.2.6 begins with these lines:

Changes since 1.2.6
- Updates for GCC 5

It is by definition impossible for any changes in the 1.2.6 distribution to have occurred *since*
(meaning: "after") 1.2.6.

In fact, "Updates for GCC 5" did not occur *since* 1.2.6; they occurred *in* 1.2.6; they were the only
advertised change in the 1.2.6 release.

I think that everywhere in the CHANGES file where you wrote "Changes since" you actually mean
"Changes in".

An exception is r2474 in which you added this line to the "Changes since 1.2.6" section:

- Updates for Clang

Because r2474 was committed after the release of 1.2.6, "Updates for Clang" did indeed occur *since*
the release of 1.2.6, so it should not appear in the same section as "Updates for GCC 5" which occurred
*in* 1.2.6.
Messages per page: