Login | Register
My pages Projects Community openCollabNet

Discussions > issues > [Issue 21] change file prop internal bug

fsvs
Discussion topic

2020-03-13: This site is going to be decommissioned and shut down very soon. Please copy and archive any data you wish to keep ASAP

Hide all messages in topic

All messages in topic

[Issue 21] change file prop internal bug

Author arlion
Full name Josh Henderson
Date 2015-12-30 06:59:39 PST
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=21



User arlion changed the following:

                What |Old value |New value
====================​====================​====================​====================​
                  Status|RESOLVED |CLOSED
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from arlion at tigris dot org Wed Dec 30 06:59:39 -0800 2015 -------
Thank You! Works!

[Issue 21] change file prop internal bug

Author arlion
Full name Josh Henderson
Date 2015-12-30 05:28:17 PST
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=21






------- Additional comments from arlion at tigris dot org Wed Dec 30 05:28:17 -0800 2015 -------
fsvs-1.2.6.tar.gz is coming directly from this website,
http://download.fsvs​-software.org/fsvs-1​.2.6.tar.gz. It is defined in the
Source0 header of the spec file.

gcc version I am using is 5.3.1.2.

[Issue 21] change file prop internal bug

Author pmarek
Full name P.Marek
Date 2015-12-29 23:40:12 PST
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=21



User pmarek changed the following:

                What |Old value |New value
====================​====================​====================​====================​
                  Status|STARTED |RESOLVED
--------------------​--------------------​--------------------​--------------------​
              Resolution| |WORKSFORME
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from pmarek at tigris dot org Tue Dec 29 23:40:12 -0800 2015 -------
Not sure what you're trying to compile, but

> helper.c: In function ‘hlp__rev_to_string’:
> helper.c:1739:14: error: storage size of ‘buffers’ isn’t constant
> static char buffers[2][(int)(siz​eof(rev)*3.32)+3];
              ^
has been fixed since r2454:

    http://fsvs.tigris.o​rg/source/browse/fsv​s?view=rev&revis​ion=2454

> 2011-04-25 22:44:42-0800 (4 years, 8 months ago)
> Workarounds for gcc-4.5 and gcc-4.6 regressions.

See
http://fsvs.tigris.o​rg/source/browse/fsv​s/branches/fsvs-1.2.​x/fsvs/src/helper.c?​r1=2454&r2=2453​&pathrev=2454
for the change.


fsvs 1.2.6 was in 2015, so it should have that fix already in - where is the
tar.gz coming from? Are you pulling the wrong branch?

[Issue 21] change file prop internal bug

Author arlion
Full name Josh Henderson
Date 2015-12-29 10:11:08 PST
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=21






------- Additional comments from arlion at tigris dot org Tue Dec 29 10:11:07 -0800 2015 -------
Here is the full paste, interesting bits are toward the end.

http://www.fpaste.or​g/305735/12422145/

and the mentioned log file in the last line:

http://www.fpaste.or​g/305737/41262814/

[Issue 21] change file prop internal bug

Author pmarek
Full name P.Marek
Date 2015-12-29 09:54:59 PST
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=21






------- Additional comments from pmarek at tigris dot org Tue Dec 29 09:54:59 -0800 2015 -------
That's just a warning, what's the error?

[Issue 21] change file prop internal bug

Author arlion
Full name Josh Henderson
Date 2015-12-29 07:27:17 PST
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=21






------- Additional comments from arlion at tigris dot org Tue Dec 29 07:27:17 -0800 2015 -------
Thank you for the clarification regarding the configure file. I must have been
looking at the official 1.2.6 package and saw the configure there.

I generated a new configure using autoconf, when I make I receive the following
error:


helper.c: In function ‘hlp__rev_to_string’:
helper.c:1753:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
Makefile:148: recipe for target 'helper.o' failed
make[1]: *** [helper.o] Error 1
make[1]: *** Waiting for unfinished jobs....
In file included from est_ops.h:15:0,
                 from ignore.c:19:


-----

Here is my output of svn update:

svn up [10:26:34]
Updating '.':
Authentication realm: <http://fsvs.tigris.org:80> CollabNet Subversion Repository
Password for 'guest':

At revision 2484.

[Issue 21] change file prop internal bug

Author pmarek
Full name P.Marek
Date 2015-12-29 06:57:37 PST
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=21



User pmarek changed the following:

                What |Old value |New value
====================​====================​====================​====================​
                  Status|REOPENED |STARTED
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from pmarek at tigris dot org Tue Dec 29 06:57:37 -0800 2015 -------
Hmmm, looking at http://fsvs.tigris.o​rg/svn/fsvs/branches​/fsvs-1.2.x/fsvs/ it
tells me "Revision 2484", so I'm not sure what kind of problem you are hitting.

Would you please show the complete "svn up" command and it's output?

No, I didn't remove ./configure. That's never been in SVN, you'll have to use
"autoconf" to build it from the "configure.ac" file; the normal autotools use
applies.

I'm planning to do a new release with that, but that'll likely take a bit of time.

[Issue 21] change file prop internal bug

Author arlion
Full name Josh Henderson
Date 2015-12-29 05:49:57 PST
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=21



User arlion changed the following:

                What |Old value |New value
====================​====================​====================​====================​
                  Status|RESOLVED |REOPENED
--------------------​--------------------​--------------------​--------------------​
              Resolution|FIXED |
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from arlion at tigris dot org Tue Dec 29 05:49:57 -0800 2015 -------
Did the configure file not make it back into the file? I don't have a configure
file to compile the package.

Also, when doing a svn log, the user, guest, cannot see any changes prior to
r2414. I tried to investigate to see if the configure fell off some where but
couldn't look at the svn log to confirm my findings.

[Issue 21] change file prop internal bug

Author pmarek
Full name P.Marek
Date 2015-12-29 02:44:17 PST
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=21



User pmarek changed the following:

                What |Old value |New value
====================​====================​====================​====================​
                  Status|STARTED |RESOLVED
--------------------​--------------------​--------------------​--------------------​
              Resolution| |FIXED
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from pmarek at tigris dot org Tue Dec 29 02:44:17 -0800 2015 -------
Please try r2484 from the fsvs-1.2.x branch.

[Issue 21] change file prop internal bug

Author pmarek
Full name P.Marek
Date 2015-12-28 23:39:11 PST
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=21






------- Additional comments from pmarek at tigris dot org Mon Dec 28 23:39:11 -0800 2015 -------
Ah, it will most probably be RA-dependent.

With file:/// or svn+ssh:// I can't reproduce - I'll try http:// next, the same
that you are using.

[Issue 21] change file prop internal bug

Author pmarek
Full name P.Marek
Date 2015-12-28 23:34:36 PST
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=21






------- Additional comments from pmarek at tigris dot org Mon Dec 28 23:34:36 -0800 2015 -------
Hrmm...
After upgrading to 1.9.3 I can't reproduce your problem (yet!), but I keep
stumbling upon other problems....


Program received signal SIGSEGV, Segmentation fault.
0x00007ffff6bb6740 in _IO_2_1_stdout_ () from /lib/x86_64-linux-gnu/libc.so.6
(gdb) bt
#0 0x00007ffff6bb6740 in _IO_2_1_stdout_ () from /lib/x86_64-linux-gnu/libc.so.6
#1 0x00007ffff78a2274 in ?? () from /usr/lib/x86_64-linu​x-gnu/libsvn_delta-1​.so.1
#2 0x00007ffff5660331 in svn_repos_finish_report () from
/usr/lib/x86_64-linu​x-gnu/libsvn_repos-1​.so.1

[Issue 21] change file prop internal bug

Author arlion
Full name Josh Henderson
Date 2015-12-28 12:06:35 PST
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=21






------- Additional comments from arlion at tigris dot org Mon Dec 28 12:06:32 -0800 2015 -------
Thank you for your quick responses, here are my subversion packages that are
currently installed.

rpm -qa | grep subversion
[15:05:28]
subversion-libs-1.9.​3-1.fc23.x86_64
subversion-1.9.3-1.fc23.x86_64
subversion-devel-1.9​.3-1.fc23.x86_64
subversion-debuginfo​-1.9.3-1.fc23.x86_64​

[Issue 21] change file prop internal bug

Author pmarek
Full name P.Marek
Date 2015-12-28 10:59:18 PST
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=21



User pmarek changed the following:

                What |Old value |New value
====================​====================​====================​====================​
                  Status|REOPENED |STARTED
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from pmarek at tigris dot org Mon Dec 28 10:59:18 -0800 2015 -------
Ah, that helps quite a bit.

Which SVN version is that?


I'll try to fix that tomorrow.

[Issue 21] change file prop internal bug

Author arlion
Full name Josh Henderson
Date 2015-12-28 06:56:49 PST
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=21






------- Additional comments from arlion at tigris dot org Mon Dec 28 06:56:48 -0800 2015 -------
Since my last post was not complete:

Here is the entire output:

http://paste.fedorap​roject.org/305472/14​513145/

[Issue 21] change file prop internal bug

Author arlion
Full name Josh Henderson
Date 2015-12-28 06:52:58 PST
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=21



User arlion changed the following:

                What |Old value |New value
====================​====================​====================​====================​
                  Status|RESOLVED |REOPENED
--------------------​--------------------​--------------------​--------------------​
              Resolution|WORKSFORME |
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from arlion at tigris dot org Mon Dec 28 06:52:58 -0800 2015 -------
I am still having the same issue. Here is another debug with the newest build.

http://paste.fedorap​roject.org/305468/45​131398/

[Issue 21] change file prop internal bug

Author pmarek
Full name P.Marek
Date 2015-12-28 03:49:23 PST
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=21



User pmarek changed the following:

                What |Old value |New value
====================​====================​====================​====================​
                  Status|STARTED |RESOLVED
--------------------​--------------------​--------------------​--------------------​
              Resolution| |WORKSFORME
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from pmarek at tigris dot org Mon Dec 28 03:49:22 -0800 2015 -------
With current compilers and SVN libraries I could reproduce this (or a very
similar) bug in my test suite.

Strange that it didn't occur earlier - perhaps some compiler optimization or
timing issue in the SVN libraries?


I "fixed" it via an additional assignment and some cleanups for compiler
warnings; please update to SVN r2480 and try again.
(Interestingly I could trigger a SVN assertion(), see debian #809209.


If it still doesn't work, please tell me the SVN version numbers, and compile
again with "configure --enable-debug" (doesn't need libgcc-debug!?); then please
run the command with an additional "-d" flag, and attach the compressed output.
Thank you!

[Issue 21] change file prop internal bug

Author arlion
Full name Josh Henderson
Date 2015-12-23 13:04:31 PST
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=21






------- Additional comments from arlion at tigris dot org Wed Dec 23 13:04:31 -0800 2015 -------
This is what was built when debug was enabled:

I attempted to install debug packages, libgcc-debug package isn't avail to me at
this time. Investigation is needed to see if I can find a similar package.

http://paste.fedorap​roject.org/304473/14​509045/

[Issue 21] change file prop internal bug

Author pmarek
Full name P.Marek
Date 2015-12-23 12:07:12 PST
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=21






------- Additional comments from pmarek at tigris dot org Wed Dec 23 12:07:04 -0800 2015 -------
You could try to run the FSVS commandline with debugging enabled (at compile
time, and then the commandline switch), and attach the (compressed!) debug output.

The segfault is "per design" - before anything bad happens, let's crash, so that
a debugger would be activated here.

[Issue 21] change file prop internal bug

Author pmarek
Full name P.Marek
Date 2015-12-23 12:03:38 PST
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=21



User pmarek changed the following:

                What |Old value |New value
====================​====================​====================​====================​
                  Status|NEW |STARTED
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from pmarek at tigris dot org Wed Dec 23 12:03:38 -0800 2015 -------
I'll look at that, but it'll take some days. Now is a bad time for bugs ;)

[Issue 21] change file prop internal bug

Author arlion
Full name Josh Henderson
Date 2015-12-23 12:00:46 PST
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=21






------- Additional comments from arlion at tigris dot org Wed Dec 23 12:00:45 -0800 2015 -------
Relevant seg fault in dmesg:

http://paste.fedorap​roject.org/304446/45​090082/

[Issue 21] New - change file prop internal bug

Author arlion
Full name Josh Henderson
Date 2015-12-23 11:58:26 PST
Message http://fsvs.tigris.o​rg/issues/show_bug.c​gi?id=21
                 Issue #|21
                 Summary|change file prop internal bug
               Component|fsvs
                 Version|current
                Platform|Linux
              OS/Version|Linux
                     URL|
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|core
             Assigned to|pmarek
             Reported by|arlion






------- Additional comments from arlion at tigris dot org Wed Dec 23 11:58:26 -0800 2015 -------
Hello,

I am a package manager currently building your package on Fedora 23. I am
compiling FSVS 1.2.6

The Libraries I am currently using are:

libapr-1.so.0()(64bit) libaprutil-1.so.0()(64bit) libc.so.6()(64bit)
libc.so.6(GLIBC_2.15)(64bit) libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.22)(64bit) libc.so.6(GLIBC_2.3)(64bit)
libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libdl.so.2()(64bit)
libdl.so.2(GLIBC_2.2.5)(64bit) libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit)
libgdbm.so.4()(64bit) libpcre.so.1()(64bit) libsvn_delta-1.so.0()(64bit)
libsvn_ra-1.so.0()(64bit) libsvn_subr-1.so.0()(64bit) rtld(GNU_HASH)

Here is a link to the current fsvs.spec file I am building your program with:

http://paste.fedorap​roject.org/304444/09​005491

Here are my results:

sudo fsvs co http://10.-.-.129/os​images/CentOS_6.7_x8​6-64/ [14:56:48]
14:56:55.335 up__change_file_prop​[update.c:1008] INTERNAL BUG
  sts->remote_status & FS_CHANGED
  Entry has already been fetched, properties too late!
[2] 8819 segmentation fault sudo fsvs co
http://10.173.0.129/​osimages/CentOS_6.7_​x86-64

Any Ideas where to go with this?

Thank You,
Messages per page: