Login | Register
My pages Projects Community openCollabNet

Discussions > users > Re: [ANNOUNCEMENT] fsvs 1.0 released

fsvs
Discussion topic

Back to topic list

Re: [ANNOUNCEMENT] fsvs 1.0 released

Author pmarek
Full name P.Marek
Date 2005-09-28 01:10:09 PDT
Message > On Wed, Sep 28, 2005 at 09:22:05AM +0200,
> Stephane Bortzmeyer <bortzmeyer at nic dot fr> wrote
> But the commit is fragile: if there is an unreadable file (here, in
> mode 0000), it still commits it. Commits should, IMHO, be atomic:
> nothing should be done if there is a problem.
>
> % fsvs commit -m Test3
> N... 0 ./secret
>
>
> An error occured: Permission denied (13)
> in ac__commit_nondir: open file "./secret" for reading
> committed 3 on 2005-09-28T07:21:43.876375Z as bortzmeyer
>
> And "secret" is indeed added in the revision 3 :-(
Well, that some kind of mis-bug :-)
I figure it's better to have 99% stored in the repository and missing only
a few files, than breaking the job (possibly from cron, where nobody looks
until the machine is down).

I believe that fsvs should not simply stop but ask the user "abort, retry,
ignore?" - with default ignore (eg. if input comes from /dev/null, as it's
the case with cron).

But you're right - that's a bug. Would you please file an issue that fsvs
doesn't cancel the commit on errors?


Thank you.


Regards,

Phil

« Previous message in topic | 1 of 1 | Next message in topic »

Messages

Show all messages in topic

Re: [ANNOUNCEMENT] fsvs 1.0 released pmarek P.Marek 2005-09-28 01:10:09 PDT
Messages per page: