Login | Register
My pages Projects Community openCollabNet

Discussions > users > FSVS 1.2.2 and Fedora 14

fsvs
Discussion topic

Hide all messages in topic

All messages in topic

RE: Re: FSVS 1.2.2 and Fedora 14

Author omarc
Full name Omar Carvajal
Date 2011-01-13 06:25:54 PST
Message I do have another compiler available, using gcc 4.3 everything worked just fine and I'm up and rolling.

Thanks for your help!

Cheers,
Omar

RE: Re: FSVS 1.2.2 and Fedora 14

Author pmarek
Full name P.Marek
Date 2011-01-13 01:22:34 PST
Message > Ah, I see, I didn't see that bug report.
>
> Sorry for bugging you with that.
Oh, never mind.

Do you have another compiler available?
If not, we'd have to rewrite these dynamic arrays...

The gcc bug is http://gcc.gnu.org/b​ugzilla/show_bug.cgi​?id=46028


Regards,

Phil


--
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

RE: Re: FSVS 1.2.2 and Fedora 14

Author omarc
Full name Omar Carvajal
Date 2011-01-12 09:46:58 PST
Message Ah, I see, I didn't see that bug report.

Sorry for bugging you with that.

Cheers,

Omar

RE: Re: FSVS 1.2.2 and Fedora 14

Author pmarek
Full name P.Marek
Date 2011-01-12 09:23:00 PST
Message > After changing it to 40, the program compiles, but now I get the following error:
>
> log.c: In function 'log__work':
> log.c:417:2: warning: 'svn_ra_get_log' is deprecated (declared at
> /usr/include/subvers​ion-1/svn_ra.h:1373)​
> CC options.c
> options.c: In function 'opt__variable_from_option':
> options.c:744:3: error: variable-sized object may not be initialized
> options.c:743:14: error: storage size of 'buffer' isn't constant
...
> I see that the definition of name is fixed at 24, as per the patch in the 1.2.x branch:
>
> struct opt__list_t {
> /** Name of the option. */
> char name[24];
> ...
>
> I am using this version of GCC:
>
> gcc (SUSE Linux) 4.5.0 20100604 [gcc-4_5-branch revision 160292]
Uh, then you'll have to fix a few of these things ...
or perhaps even have to rewrite them to use a char* and alloca() or something like that.

This is a known bug; doesn't seem to have to changed in the last year:
  http://bugs.debian.o​rg/cgi-bin/bugreport​.cgi?bug=564990


I'm sorry - maybe you can simple use 4.3 or 4.4?


Regards,

Phil



--
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

RE: Re: FSVS 1.2.2 and Fedora 14

Author omarc
Full name Omar Carvajal
Date 2011-01-12 09:04:42 PST
Message After changing it to 40, the program compiles, but now I get the following error:

log.c: In function 'log__work':
log.c:417:2: warning: 'svn_ra_get_log' is deprecated (declared at /usr/include/subvers​ion-1/svn_ra.h:1373)​
     CC options.c
options.c: In function 'opt__variable_from_option':
options.c:744:3: error: variable-sized object may not be initialized
options.c:743:14: error: storage size of 'buffer' isn't constant
options.c:743:14: warning: unused variable 'buffer'
options.c:753:1: warning: control reaches end of non-void function
make[1]: *** [options.o] Error 1
make: *** [default-target] Error 2

I see that the definition of name is fixed at 24, as per the patch in the 1.2.x branch:

struct opt__list_t {
        /** Name of the option. */
        char name[24];
...

I am using this version of GCC:

gcc (SUSE Linux) 4.5.0 20100604 [gcc-4_5-branch revision 160292]

Cheers,

Omar

RE: Re: FSVS 1.2.2 and Fedora 14

Author pmarek
Full name P.Marek
Date 2011-01-12 08:40:58 PST
Message > It doesn't, I should have mentioned that, I already tried it.
>
> I am using the current 1.2.x branch to compile.
Please try to put a 40 instead of the expression (int)sizeof(...) etc.
Strange - that should be a constant.

What compiler version is that?


Regards,

Phil

--
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

RE: Re: FSVS 1.2.2 and Fedora 14

Author omarc
Full name Omar Carvajal
Date 2011-01-12 08:12:49 PST
Message It doesn't, I should have mentioned that, I already tried it.

I am using the current 1.2.x branch to compile.

Cheers,

Omar

RE: Re: FSVS 1.2.2 and Fedora 14

Author pmarek
Full name P.Marek
Date 2011-01-12 07:56:38 PST
Message Hello Omar!

> I am experiencing a similar problem with openSUSE 11.3, gcc version 4.5 and Subversion
> 1.6.9:
>
> Not seen: S_ISDOOR
> CC helper.c
> helper.c: In function 'hlp__rev_to_string':
> helper.c:1741:14: error: storage size of 'buffers' isn't constant
...
> In this case it does seem to be related to the version of Subversion doesn't it?
>
> Thanks for any help you can provide on this!
I think this might be the same problem.

Does my patch (or the current 1.2.x branch) work for you?


Regards,

Phil


--
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

RE: Re: FSVS 1.2.2 and Fedora 14

Author omarc
Full name Omar Carvajal
Date 2011-01-12 07:42:14 PST
Message Hi Philipp!

I am experiencing a similar problem with openSUSE 11.3, gcc version 4.5 and Subversion 1.6.9:

Not seen: S_ISDOOR
     CC helper.c
helper.c: In function 'hlp__rev_to_string':
helper.c:1741:14: error: storage size of 'buffers' isn't constant
helper.c:1741:14: warning: unused variable 'buffers'
helper.c: In function 'hlp__rename_to_unique':
helper.c:1879:2: warning: 'svn_io_open_unique_file2' is deprecated (declared at /usr/include/subvers​ion-1/svn_io.h:219)
helper.c: In function 'hlp__rev_to_string':
helper.c:1755:1: warning: control reaches end of non-void function
make[1]: *** [helper.o] Error 1
make: *** [default-target] Error 2

In this case it does seem to be related to the version of Subversion doesn't it?

Thanks for any help you can provide on this!

Cheers,

Omar

Re: FSVS 1.2.2 and Fedora 14

Author Mark J Hewitt <mjh at elsabio dot demon dot co dot uk>
Full name Mark J Hewitt <mjh at elsabio dot demon dot co dot uk>
Date 2011-01-11 07:25:29 PST
Message Hmm ... Well two bad comments and I upset the author too (though that
was due to an over eager spelling checker) - not a bad hit rate for a
Tuesday morning - I think I'd better keep quiet for a while now :-)

Thanks Philipp (with the two 'p's and a wavy red underline :-).

Mark.

On 11/01/11 14:37, P.Marek wrote:
> Hello Mark!
>
>> Well, probably Subversion 1.6.13 actually.
> No, I think it's gcc.
>
>> Seems like some fixed sized strictures in the svn api have now become
>> dynamically sized, thus invalidating the static arrays that fsvs declares.
> No, I took sizeof(char*) (wrong!) + strlen("CONST STRING") - and one of these is no
> longer wanted by the compiler.
>
>> I have not looked at this yet (other than noticing that I can't build
>> for Fedora 14 atm!) - does anyone have the Philip-approved patches ? :-)
> First, it's "Philipp" with 3 "p"; and second, does either of these count?
>
> http://fsvs.tigris.o​rg/source/browse/fsv​s?view=rev&revis​ion=2448
>

Re: FSVS 1.2.2 and Fedora 14

Author pmarek
Full name P.Marek
Date 2011-01-11 06:38:06 PST
Message Hello Mark!

> Well, probably Subversion 1.6.13 actually.
No, I think it's gcc.

> Seems like some fixed sized strictures in the svn api have now become
> dynamically sized, thus invalidating the static arrays that fsvs declares.
No, I took sizeof(char*) (wrong!) + strlen("CONST STRING") - and one of these is no
longer wanted by the compiler.

> I have not looked at this yet (other than noticing that I can't build
> for Fedora 14 atm!) - does anyone have the Philip-approved patches ? :-)
First, it's "Philipp" with 3 "p"; and second, does either of these count?

    http://fsvs.tigris.o​rg/source/browse/fsv​s?view=rev&revis​ion=2448


Thank you very much!


Regards,

Phil


--
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!
Attachments

FSVS 1.2.2 and Fedora 14

Author elsabio
Full name mark j hewitt
Date 2011-01-11 06:07:36 PST
Message Well, probably Subversion 1.6.13 actually.

Seems like some fixed sized strictures in the svn api have now become
dynamically sized, thus invalidating the static arrays that fsvs declares.

CC options.c
options.c: In function ‘opt__variable_from_option’:
options.c:746:3: error: variable-sized object may not be initialized
options.c:745:14: error: storage size of ‘buffer’ isn’t constant
options.c:745:14: warning: unused variable ‘buffer’
options.c:755:1: warning: control reaches end of non-void function
make[1]: *** [options.o] Error 1

I have not looked at this yet (other than noticing that I can't build
for Fedora 14 atm!) - does anyone have the Philip-approved patches ? :-)

Mark.
Messages per page: